feat(directory-browser): add custom dialog for project and folder select#45
Merged
Conversation
- Add DirectoryBrowserDialog component with breadcrumb navigation, filtering, and keyboard shortcuts - Implement browseDirectories server endpoint for listing directory contents - Replace native picker with custom dialog in add project and add folder flows - Add addProjectBaseDirectory setting to remember last project path - Simplify Sidebar state management by consolidating add-project logic - Support keyboard shortcuts (↑/↓ to navigate, Enter to select, Backspace/Cmd+Enter for navigation) - Add integration guard test for directory browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created reusable
DirectoryBrowserDialogcomponent for browsing and selecting directoriesImplemented
browseDirectories()backend function inworkspaceEntries.ts~and~/)../) relative to cwdRefactored "Add Project" flow in Sidebar to use directory browser dialog
Refactored "Add Folder" flow in ComposerAttachmentsPopover to use directory browser dialog
../) for convenienceAdded
addProjectBaseDirectorysetting to persist last used directoryTesting
Unit tests for
browseDirectories()covering:~/)../)Integration test for settings persistence of
addProjectBaseDirectoryIntegration guard test added for directory browser wiring
Manual testing: both "Add Project" and "Add Folder" flows use dialog successfully